Update and pin jquery-serializejson #3084
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving from 2.4.2 to 3.2.1 for our use seems have no breaking changes: https://github.com/marioizquierdo/jquery.serializeJSON/blob/8a2f2cfebd928b65509181bcdf01f8de243ed573/CHANGELOG.md Importmap was used to download and pin the CDN package. Combined with the node-resolve plugin for rollup, this is working for me on builds using the rolled up assets as well as experimental builds using only importmaps.
taylor-steve
force-pushed
the
pin-jquery-serializejson
branch
from
c34c464
to
180a7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from 2.4.2 to 3.2.1 for our use seems have no breaking changes: https://github.com/marioizquierdo/jquery.serializeJSON/blob/8a2f2cfebd928b65509181bcdf01f8de243ed573/CHANGELOG.md
Importmap was used to download and pin the CDN package, in lieu of the old vendor copy. Combined with the node-resolve plugin for rollup, this is working for me on builds using the rolled-up assets as well as experimental builds using only importmaps.