Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RIIIF to 2.0 #1986

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Update RIIIF to 2.0 #1986

merged 3 commits into from
Mar 29, 2019

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Apr 5, 2018

No description provided.

@mejackreed
Copy link
Contributor

Does the riiif initializer need to change here at all? we have that deprecation warning that something will change in 2.0

@jcoyne
Copy link
Member Author

jcoyne commented Apr 5, 2018

@jcoyne
Copy link
Member Author

jcoyne commented Apr 5, 2018

Ah, there was a typo in that code. Should be fixed now.

@mejackreed
Copy link
Contributor

Do you know if there are any breaking changes here we should worry about for our downstream consumers?

@jcoyne
Copy link
Member Author

jcoyne commented Apr 10, 2018

@mejackreed I don't know. I suspect that config change might be it.

@aeschylus
Copy link
Contributor

Bundler could not find compatible versions for gem "rails":
  In Gemfile:
    rails (~> 5.1.6)
    blacklight-spotlight was resolved to 1.5.1, which depends on
      blacklight (~> 6.3) was resolved to 6.14.1, which depends on
        rails (< 6, >= 4.2)
    blacklight-spotlight was resolved to 1.5.1, which depends on
      rails (~> 5.1)
    engine_cart (~> 2.0) was resolved to 2.0.1, which depends on
      rails
Bundler could not find compatible versions for gem "riiif":
  In Gemfile:
    riiif (~> 1.0)
    blacklight-spotlight was resolved to 1.5.1, which depends on
      riiif (~> 2.0)

@aeschylus
Copy link
Contributor

@no-reply
Copy link

no-reply commented Jan 4, 2019

Anyone know what's needed to complete this upgrade?

@dunn
Copy link
Contributor

dunn commented Jan 4, 2019

Can this be rebased?

@jcoyne
Copy link
Member Author

jcoyne commented Feb 12, 2019

@dunn it has been rebased.

@dunn
Copy link
Contributor

dunn commented Feb 14, 2019

Oop, right now the build is failing because of rubocop.

@jcoyne
Copy link
Member Author

jcoyne commented Feb 14, 2019

@dunn right, which is why I made #2135

@jcoyne jcoyne force-pushed the update_riiif branch 2 times, most recently from dccf57d to b11cc7d Compare February 28, 2019 15:37
@dunn
Copy link
Contributor

dunn commented Mar 28, 2019

The Rails 5.1/Ruby 2.4 build is consistently failing with:

     Selenium::WebDriver::Error::SessionNotCreatedError:
       session not created: This version of ChromeDriver only supports Chrome version 74
         (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.4.0-101-generic x86_64)

https://travis-ci.org/projectblacklight/spotlight/jobs/512607508#L3715

@dunn dunn mentioned this pull request Mar 28, 2019
@dunn dunn self-requested a review March 29, 2019 18:18
@dunn dunn merged commit 78cbf24 into master Mar 29, 2019
@dunn dunn deleted the update_riiif branch March 29, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants