fix: fft missing break #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah - looks like that |
|
Anyone reading this other than @mdionisio ? |
|
I can only say that: if 'ne10_radix_8_butterfly_float32_c' is well implemented my fix is correct. The previous one was not bugged for result because the generic function is called but is bugger for performance because So with my fix the _c version of fft has better performance. I'm not able to run test on arm with neon now. But in teory if test continue o run correctly it means that all is ok because the neon version is not changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about the fix and I'm not able now to execute test because I'm on on intel machine. But only reading the code it seams that there is a missing break.