Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umoci: update to get tar writing fix #597

Conversation

mikemccracken
Copy link
Contributor

move umoci version to the commit with the fix for correctly closing tarwriter in all cases, avoiding creation of layers that make gnu tar sad.

What type of PR is this?
bug

Which issue does this PR fix:

$ tar tvzf oci/blobs/sha256/bc7f2c15116d3da36aa493221dcf736cbe027f64f3e32b157aafb83da7cba35e
...
-rw-r--r-- 0/0 32064 2024-02-21 19:44 var/log/faillog
-rw-rw-r-- 0/43 292584 2024-02-21 19:44 var/log/lastlog
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

What does this PR do / Why do we need it:

while golang based container tools ignore this EOF, which is fine because it only happens after the last file has been read, many scanners use gnu tar, which errors out and can cause problems.

If an issue # is not available please add repro steps and logs showing the issue:

see project-stacker/umoci#4

Testing done on this change:

see project-stacker/umoci#4

Will this break upgrades or downgrades?
no

Does this PR introduce any user-facing change?:
no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mikemccracken mikemccracken force-pushed the 2024.02.22/main/update-umoci-tarlayerfix branch 6 times, most recently from 7e53b28 to 1155f43 Compare February 29, 2024 21:49
move umoci version to the commit with the fix for correctly closing
tarwriter in all cases, avoiding creation of layers that make gnu tar sad.

Signed-off-by: Michael McCracken <[email protected]>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.15%. Comparing base (e627e90) to head (1155f43).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files          64       64           
  Lines        7525     7525           
=======================================
  Hits         4301     4301           
  Misses       2481     2481           
  Partials      743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallyn hallyn merged commit ee32587 into project-stacker:main Mar 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants