Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure ResourceName and InstanceName columns #521

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

esebesto
Copy link
Contributor

Make sure that Azure ResourceName and InstanceName columns are populated with data

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.9%. Comparing base (b0f4815) to head (9525dde).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #521     +/-   ##
=======================================
+ Coverage   93.8%   93.9%   +0.1%     
=======================================
  Files         62      62             
  Lines       4689    4687      -2     
  Branches     665     664      -1     
=======================================
+ Hits        4399    4400      +1     
+ Misses       151     149      -2     
+ Partials     139     138      -1     

Copy link
Contributor

@bacciotti bacciotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. It works.

I think we can keep ResourceName for now.

@esebesto esebesto merged commit 02bc748 into main Jul 30, 2024
4 checks passed
@esebesto esebesto deleted the esebesto/more_rg_export_fixes branch July 30, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants