more prep for glue #5465
Merged
more prep for glue #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskarb
added
the
smoke-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5465 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 371 371
Lines 31631 31631
Branches 3386 3386
=====================================
+ Hits 29772 29774 +2
+ Misses 1210 1207 -3
- Partials 649 650 +1 |
djnakabaale
previously approved these changes
Jan 23, 2025
djnakabaale
previously approved these changes
Jan 23, 2025
lcouzens
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5551
Description
This change will update from where the default S3 access key and secret are pulled. Add koku-aws secret to the CJIs.
Testing