Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5551] utilize AWS Glue Data Catalog for PR smoke tests #5461

Merged
merged 18 commits into from
Jan 28, 2025
Merged

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 22, 2025

Jira Ticket

COST-5551

Description

This change will enable running smoke tests utilizing Glue Data Catalog in ephemeral.

To configure your local env to utilize the Glue Data Catalog, set the following env variables:

  • SCHEMA_SUFFIX=_{username} # your username with a leading underscore
  • TRINO_S3A_OR_S3=s3
  • HIVE_PROPERTIES_FILE=glue.properties
  • GLUE_PROPERTIES_FILE=hive.properties

Testing

  1. PR smoke tests

Release Notes

  • proposed release note
* [COST-5551](https://issues.redhat.com/browse/COST-5551) switch PR checks to utilize Glue Data Catalog

@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 22, 2025
@maskarb
Copy link
Member Author

maskarb commented Jan 22, 2025

/retest

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (7881165) to head (e53d997).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5461     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        371     371             
  Lines      31631   31631             
  Branches    3386    3386             
=======================================
- Hits       29772   29770      -2     
- Misses      1210    1211      +1     
- Partials     649     650      +1     

@maskarb maskarb changed the title switch smokes over to Glue [COST-5551] utilize AWS Glue Data Catalog for PR smoke tests Jan 28, 2025
@maskarb maskarb marked this pull request as ready for review January 28, 2025 16:43
@maskarb maskarb requested review from a team as code owners January 28, 2025 16:43
@maskarb maskarb merged commit f87e8b3 into main Jan 28, 2025
14 checks passed
@maskarb maskarb deleted the glue-smokes branch January 28, 2025 19:10
maskarb added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants