-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5551] utilize AWS Glue Data Catalog for PR smoke tests #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskarb
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jan 22, 2025
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5461 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 371 371
Lines 31631 31631
Branches 3386 3386
=======================================
- Hits 29772 29770 -2
- Misses 1210 1211 +1
- Partials 649 650 +1 |
Co-authored-by: maskarb <[email protected]>
maskarb
changed the title
switch smokes over to Glue
[COST-5551] utilize AWS Glue Data Catalog for PR smoke tests
Jan 28, 2025
lcouzens
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5551
Description
This change will enable running smoke tests utilizing Glue Data Catalog in ephemeral.
To configure your local env to utilize the Glue Data Catalog, set the following env variables:
SCHEMA_SUFFIX=_{username}
# your username with a leading underscoreTRINO_S3A_OR_S3=s3
HIVE_PROPERTIES_FILE=glue.properties
GLUE_PROPERTIES_FILE=hive.properties
Testing
Release Notes