-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5492] Handle special characters in tag queries #5336
[COST-5492] Handle special characters in tag queries #5336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5336 +/- ##
=====================================
Coverage 94.0% 94.0%
=====================================
Files 375 375
Lines 31616 31624 +8
Branches 4658 4658
=====================================
+ Hits 29734 29742 +8
- Misses 1201 1203 +2
+ Partials 681 679 -2 |
/retest |
/retest |
/retest |
1 similar comment
/retest |
Co-authored-by: Sam Doran <[email protected]>
There are three places where the same string is being sanitized. Two are still using the regex method and one is using a translation table. The sanitizing functionality could be put into a function for consistency instead of doing the same thing in three different places. |
Co-authored-by: Sam Doran <[email protected]>
Co-authored-by: Sam Doran <[email protected]>
Co-authored-by: Sam Doran <[email protected]>
Jira Ticket
COST-5492
Description
This change will handle special characters in tag queries, for instance white spaces and semicolons.
Testing
app test
orapp;test
?group_by[tag:app test]=*
or?group_by[tag:app;test]=*&order_by[tag:app;test]=asc
Release Notes