-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint upgrade #1606
Merged
Merged
Eslint upgrade #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and reformatting file
They now also check that inherited methods have same returns ... so also cleaned up here. And also make sure we only throw errors.
lauckhart
previously requested changes
Jan 6, 2025
# Conflicts: # package-lock.json
lauckhart
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades eslint to v9 including config and relevant deps.
It also addresses all new eslint errors reported by this versions. Please check the ocmmits
It also includes upgrade of @noble/curves which changed types and required an adjustment to access P256 curve "p" parameter ... I validated that the new place returns the same value as needed.
@lauckhart Please especially check 4c8f050 that in fact the new behavior is like the old one ... tests are all passing