Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint upgrade #1606

Merged
merged 14 commits into from
Jan 6, 2025
Merged

Eslint upgrade #1606

merged 14 commits into from
Jan 6, 2025

Conversation

Apollon77
Copy link
Collaborator

@Apollon77 Apollon77 commented Jan 5, 2025

This PR upgrades eslint to v9 including config and relevant deps.

It also addresses all new eslint errors reported by this versions. Please check the ocmmits

It also includes upgrade of @noble/curves which changed types and required an adjustment to access P256 curve "p" parameter ... I validated that the new place returns the same value as needed.

@lauckhart Please especially check 4c8f050 that in fact the new behavior is like the old one ... tests are all passing

Copy link

semanticdiff-com bot commented Jan 5, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  packages/nodejs-shell/src/shell/cmd_tlv.ts  73% smaller
  packages/protocol/src/codec/MessageCodec.ts  64% smaller
  packages/nodejs-ble/src/BlenoBleServer.ts  62% smaller
  codegen/src/mom/spec/translate-cluster.ts  60% smaller
  package.json  59% smaller
  packages/nodejs/src/storage/StorageBackendJsonFile.ts  55% smaller
  packages/testing/src/global-definitions.ts  55% smaller
  packages/general/src/net/UdpChannel.ts  53% smaller
  packages/protocol/src/common/Scanner.ts  53% smaller
  packages/node/test/node/mock-node.ts  51% smaller
  packages/general/src/util/Promises.ts  28% smaller
  packages/general/src/util/Observable.ts  26% smaller
  packages/nodejs/test/storage/StorageBackendJsonFileTest.ts  17% smaller
  chip-testing/src/storage/StorageBackendAsyncJsonFile.ts  17% smaller
  packages/general/src/storage/StorageBackendMemory.ts  17% smaller
  packages/node/test/endpoints/BridgedNodeEndpointTest.ts  17% smaller
  packages/nodejs/test/IntegrationTest.ts  17% smaller
  packages/protocol/test/mdns/MdnsTest.ts  17% smaller
  packages/testing/src/docker/edit.ts  17% smaller
  packages/general/src/net/UdpInterface.ts  16% smaller
  chip-testing/src/storage/StorageBackendSyncJsonFile.ts  16% smaller
  packages/node/src/behavior/internal/Reactors.ts  16% smaller
  codegen/src/clusters/NumberConstants.ts  14% smaller
  packages/general/src/util/Construction.ts  12% smaller
  packages/create/src/run.ts  12% smaller
  packages/testing/src/web.ts  12% smaller
  packages/general/src/net/UdpMulticastServer.ts  10% smaller
  packages/general/src/util/Mutex.ts  9% smaller
  packages/nodejs/src/environment/NodeJsEnvironment.ts  7% smaller
  packages/nodejs-ble/src/BleScanner.ts  7% smaller
  packages/react-native/src/ble/BleScanner.ts  7% smaller
  packages/testing/src/mocks/time.ts  3% smaller
  CHANGELOG.md Unsupported file format
  chip-testing/src/GenericTestApp.ts  0% smaller
  eslint.config.mjs  0% smaller
  package-lock.json Unsupported file format
  packages/general/package.json  0% smaller
  packages/general/src/crypto/Spake2p.ts  0% smaller
  packages/general/src/util/Error.ts  0% smaller
  packages/general/src/util/GeneratedClass.ts  0% smaller
  packages/matter.js/src/cluster/server/OperationalCredentialsServer.ts  0% smaller
  packages/model/src/models/Children.ts  0% smaller
  packages/protocol/package.json  0% smaller
  packages/tools/tsc/tsconfig.base.json  0% smaller

lauckhart and others added 8 commits January 5, 2025 13:00
@Apollon77 Apollon77 marked this pull request as ready for review January 6, 2025 12:05
@Apollon77 Apollon77 requested a review from lauckhart January 6, 2025 12:05
@pullapprove pullapprove bot requested review from turon, vves and woody-apple January 6, 2025 12:05
packages/nodejs-ble/src/BlenoBleServer.ts Outdated Show resolved Hide resolved
codegen/src/clusters/NumberConstants.ts Show resolved Hide resolved
packages/general/src/util/Error.ts Outdated Show resolved Hide resolved
packages/general/src/util/Promises.ts Outdated Show resolved Hide resolved
packages/general/src/util/Observable.ts Outdated Show resolved Hide resolved
packages/general/src/util/Error.ts Outdated Show resolved Hide resolved
@Apollon77 Apollon77 requested a review from lauckhart January 6, 2025 15:45
@Apollon77 Apollon77 merged commit af5a068 into main Jan 6, 2025
36 checks passed
@Apollon77 Apollon77 deleted the eslint-upg branch January 6, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants