Change representation of PrivateKey to not use String #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work. First glance looks fine to me, however I am currently on vacation and only have a phone with me ;) I can have another look at some point next week, sorry for the slow response. @gvolpe any thoughts? I think this is binary breaking as it changes the public interface of |
froth
reviewed
Jul 10, 2024
|
@froth I leave it up to you guys, I don't use this library at all these days, don't wait for my review :) |
Co-authored-by: Frederick Roth <[email protected]>
froth
approved these changes
Jul 25, 2024
|
@hunterpayne thanks for your work. I like the changes and will try and merge them today. I will most likely have to change the base branch to series/2.0. I will try to change your pull request to reflect that, if I don't have the permissions to do so I will have to ask you to do that. |
Closed
froth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the JwtSecretKey class to use an Array of Characters, byte array or PrivateKey.