Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Configure rennovate to exclude cheerio package #98

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

vipulgupta2048
Copy link
Member

@vipulgupta2048 vipulgupta2048 commented Aug 15, 2024

Docusaurus uses a local search plugin which requires overrides to be in place for it to function correctly.
Without it the build will continue to break as rennovate would keep updating the override section dependencies that I am setting.

Example: Made #96, renovate made #97 to revert my change, and now I am making #99 to revert rennovate's change after this gets merged.

Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]

Copy link

github-actions bot commented Aug 15, 2024

Website deployed to CF Pages, 👀 preview link https://e2e6b75c.docusaurus-builder.pages.dev

@flowzone-app flowzone-app bot enabled auto-merge August 15, 2024 07:38
@vipulgupta2048 vipulgupta2048 force-pushed the vipulgupta2048/respect-override branch from 220654f to 88894b7 Compare August 15, 2024 08:07
Copy link
Contributor

@klutchell klutchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you only need to have Renovate ignore a specific package why not do this?

{
  "extends": ["github>balena-io/renovate-config"],
  "packageRules": [
    {
      "matchDatasources": ["npm"],
      "matchPackageNames": ["cheerio"],
      "enabled": false
    }
  ] 
}

@vipulgupta2048
Copy link
Member Author

Right now we override two packages, but let me get that down to one.

@vipulgupta2048 vipulgupta2048 force-pushed the vipulgupta2048/respect-override branch from 88894b7 to 1a54910 Compare August 15, 2024 21:34
@vipulgupta2048 vipulgupta2048 changed the title patch: Configure rennovate to respect overrides in package.json patch: Configure rennovate to exclude cheerio package Aug 15, 2024
@flowzone-app flowzone-app bot merged commit 37c5fab into master Aug 16, 2024
48 checks passed
@flowzone-app flowzone-app bot deleted the vipulgupta2048/respect-override branch August 16, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants