Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.8 support #1224

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Drop Python 3.8 support #1224

merged 1 commit into from
Oct 19, 2024

Conversation

medihack
Copy link
Member

@medihack medihack commented Oct 17, 2024 •
edited
Loading

Drops Python 3.8 support. (Removing asgiref dependency from non-Django code will be done in a separate PR).

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@medihack medihack requested a review from a team as a code owner October 17, 2024 22:28
@github-actions github-actions bot added PR type: breaking 💥 Contains breaking changes PR type: dependencies 🤖 Contains only dependencies updates labels Oct 17, 2024
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  procrastinate
  schema.py
  procrastinate/contrib/django
  migrations_utils.py
  procrastinate/sql
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

ewjoachim
ewjoachim approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !
(I think this could even be in v2, but no problem doing it in v3)

@ewjoachim ewjoachim merged commit df98e61 into procrastinate-org:v3 Oct 19, 2024
13 checks passed
@ewjoachim ewjoachim mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

Assignees
No one assigned
Labels
PR type: breaking 💥 Contains breaking changes PR type: dependencies 🤖 Contains only dependencies updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@medihack @ewjoachim