feat: allow cleaning of cancelled and aborted jobs

[katlyn]

Adds additional parameters to the builtin remove_old_jobs task to allow removing cancelled and aborted jobs in addition to failed and succeeded. Closes #1145.

Successful PR Checklist:

• Tests
  • (not applicable?)
• Documentation
  • (not applicable?)

PR label(s):

• PR type: breaking 💥 Contains breaking changes
• PR type: feature ⭐️ Contains new features
• PR type: bugfix 🕵️ Contains bug fix
• PR type: miscellaneous 👾 Contains misc changes
• PR type: dependencies 🤖 Contains only dependencies updates
• PR type: documentation 📚 Contains documentation updates

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
procrastinate
manager.py
Project Total

This report was generated by python-coverage-comment-action

[medihack]

Great, thanks a lot for the contribution! LGTM.

@ewjoachim Do you have something to add? Otherwise, I will merge it into the main branch and make a minor release. Also, how about renaming remove_error resp. include_error to remove_failed resp. include_failed for the v3 release? Would look a bit more consistent to me.

[ewjoachim]

Congratulation for you first PR in Procrastinate, it seems perfectly good.

[ewjoachim]

Also, how about renaming remove_error resp. include_error to remove_failed resp. include_failed for the v3 release? Would look a bit more consistent to me.

Yup.

Also, we need to be more consistent in the docstrings regarding the argument types. I believe they're not needed and sphinx can read them from type annotations, but we should make sure of that and fix it everywhere.