Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: group dependabot updates when minor/patch #15

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jmeridth
Copy link
Contributor

@jmeridth jmeridth commented Jun 5, 2024

  • change dependabot config to group dependencies
    • leave major dependency updates to their own PR so they stand out and are tested correctly
    • prefix the PRs with chore(deps) to adhere to conventional commits
  • change GitHub Actions to use SHAs instead of tags
    • Why?
      • To prevent supply chain attack. Tags can move. They are mutable. SHAs are not.
    • used frizbee
      • ran frizbee ghactions -d .github/workflows locally
      • also fixes formatting

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@jmeridth jmeridth requested review from a team as code owners June 5, 2024 00:08
@jmeridth jmeridth force-pushed the jm_group_dependency_updates branch 2 times, most recently from f556eeb to 3229c7b Compare June 5, 2024 21:57
leave major dependency updates to their own PR so they stand out and are tested correctly

prefix the PRs with `chore(deps)` to adhere to conventional commits

used [frizbee](https://github.com/stacklok/frizbee)

ran `frizbee ghactions -d .github/workflows` to change from tags to SHAs on github actions
also fixes formatting

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth force-pushed the jm_group_dependency_updates branch from 3229c7b to 63aac0f Compare June 5, 2024 22:01
@bmanuel bmanuel merged commit 302f984 into procore-oss:main Jun 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants