Replace jnp.row_stack with jnp.vstack #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Following NumPy's [NEP 52](https://numpy.org/neps/nep-0052-python-api-cleanup.html) API cleanup, np.row_stack is being removed, as it is a simple alias of np.vstack. JAX is following suit by deprecating jnp.row_stack in jax-ml/jax#17233. Note that jnp.vstack is an identical replacement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Following NumPy's NEP 52 API cleanup,
np.row_stackis being removed, as it is a simple alias ofnp.vstack. JAX is following suit by deprecatingjnp.row_stackin jax-ml/jax#17233. Note thatjnp.vstackis an identical replacement.