ci: Modularize CI pipeline and test Python >= 3.11 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomass-dev
force-pushed
the
backend-coverage
branch
from
92602fa to
5ee25d0
Compare
thomass-dev
changed the title
thomass-dev
force-pushed
the
backend-coverage
branch
from
5ee25d0 to
0cf8b93
Compare
thomass-dev
changed the title
>=3.9
thomass-dev
force-pushed
the
backend-coverage
branch
9 times, most recently
from
11782ad to
a5876f5
Compare
thomass-dev
force-pushed
the
backend-coverage
branch
3 times, most recently
from
44379a2 to
894569a
Compare
thomass-dev
force-pushed
the
backend-coverage
branch
6 times, most recently
from
165f804 to
1eac11e
Compare
rouk1
previously approved these changes
Sep 27, 2024
thomass-dev
force-pushed
the
backend-coverage
branch
from
0e041a8 to
267fe0c
Compare
thomass-dev
changed the title
>=3.9>=3.9
|
CI cache and the Makefile refactor are both important changes that are less controversial; could you open a separate PR for them? |
thomass-dev
force-pushed
the
backend-coverage
branch
5 times, most recently
from
0636409 to
81399db
Compare
thomass-dev
force-pushed
the
backend-coverage
branch
from
81399db to
71f0b32
Compare
augustebaum
previously approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Alright, the split of the workflows is great and ready to be merged.
One last thing is we want everything to be all green, all the time. Hence, we'll add back the Python 3.9 and 3.10 workflows when we actually address #390
augustebaum
changed the title
>=3.9
augustebaum
changed the title
augustebaum
approved these changes
Oct 3, 2024
thomass-dev
added a commit
that referenced
this pull request
Dec 2, 2024
- Remove reference of `Makefile` in workflow's instructions to build front-end - Use matrix to test back-end on all versions of python `>=3.11` - Trigger CI tasks at job level instead of workflow level - Use one and only entry-point to define if pipeline succeed `ci-all-green` --- Example: https://github.com/probabl-ai/skore/actions/runs/11146672648 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefilein workflow's instructions to build front-end>=3.9(only success on3.12is mandatory)ci-all-greenExample: https://github.com/probabl-ai/skore/actions/runs/11146672648