Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Temporarily fix the sphinx pipeline by downloading our own skrub cache #1197

Merged
merged 1 commit into from
Jan 22, 2025
Merged

ci: Temporarily fix the sphinx pipeline by downloading our own skrub cache #1197

merged 1 commit into from
Jan 22, 2025

Conversation

thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Jan 22, 2025 •
edited
Loading

Temporarily fix the sphinx pipeline by downloading the skrub cache, which i put directly on our bucket under a random directory.

skrub using the user home to cache data, i set the home envar.

image

Content of the archive:

skrub_data/
skrub_data/openml/
skrub_data/openml/employee_salaries.csv
skrub_data/openml/open_payments.csv
skrub_data/openml/openml/
skrub_data/openml/openml/openml.org/
skrub_data/openml/openml/openml.org/api/
skrub_data/openml/openml/openml.org/api/v1/
skrub_data/openml/openml/openml.org/api/v1/json/
skrub_data/openml/openml/openml.org/api/v1/json/data/
skrub_data/openml/openml/openml.org/api/v1/json/data/42125.gz
skrub_data/openml/openml/openml.org/api/v1/json/data/features/
skrub_data/openml/openml/openml.org/api/v1/json/data/features/42125.gz
skrub_data/openml/openml/openml.org/api/v1/json/data/features/42738.gz
skrub_data/openml/openml/openml.org/api/v1/json/data/qualities/
skrub_data/openml/openml/openml.org/api/v1/json/data/qualities/42125.gz
skrub_data/openml/openml/openml.org/api/v1/json/data/qualities/42738.gz
skrub_data/openml/openml/openml.org/api/v1/json/data/42738.gz
skrub_data/openml/openml/openml.org/data/
skrub_data/openml/openml/openml.org/data/v1/
skrub_data/openml/openml/openml.org/data/v1/download/
skrub_data/openml/openml/openml.org/data/v1/download/21718841.gz
skrub_data/openml/openml/openml.org/data/v1/download/22044787.gz

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Documentation preview @ 393ceef

@thomass-dev thomass-dev marked this pull request as ready for review January 22, 2025 03:20
@thomass-dev thomass-dev changed the title ci: Temporarily fix sphinx pipeline by downloading our own skrub cache ci: Temporarily fix the sphinx pipeline by downloading our own skrub cache Jan 22, 2025
thomass-dev
thomass-dev commented Jan 22, 2025
View reviewed changes
.github/workflows/sphinx.yml
Comment on lines +109 to +113
- shell: bash
run: wget -qO- "${SKRUB_DATA_URL}" | tar -zxvf - -C "${HOME}"
env:
SKRUB_DATA_URL: https://skore.probabl.ai/f355443be646d49eab1aa76e29dfd0a8/skrub-data.tar.gz
HOME: ${{ github.workspace }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think a checksum should be added? As this is temporary, i don't think so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

auguste-probabl
auguste-probabl approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@auguste-probabl auguste-probabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me!

@thomass-dev thomass-dev merged commit 10e1c0f into main Jan 22, 2025
13 checks passed
@thomass-dev thomass-dev deleted the skrub-data-qad-fix branch January 22, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auguste-probabl auguste-probabl auguste-probabl approved these changes

@rouk1 rouk1 Awaiting requested review from rouk1 rouk1 is a code owner

Assignees

@thomass-dev thomass-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomass-dev @auguste-probabl