-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove tempfiles from docs #1193
Conversation
Coverage Report for backend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this solution because it makes all the examples dependent on one-another. If example 1 fails halfway through, then clear
won't be run and example 2 will start with a non-empty project, which could make it fail, etc.
But the |
Is this likely to happen? Or it will trigger a red CI and therefore shouldn't land in main? (unless we force it) |
Yes, tests fail all the time, and we would prefer that 1 example failed rather than all of them; that way it's easier to understand what went wrong and fix things Another thing I thought of later is that this problem prevents us from running the examples in parallel |
I can't find any alternative solution for now to answer to all our goals. I created an issue to formalize this: #1200. In the mean time, if it's ok for you, I'd like to proceed with this solution to remove tempfile for this afternoon. |
To mitigate this could you follow https://sphinx-gallery.github.io/stable/configuration.html#abort-build-on-first-fail? This way if an example fails, we can see quicker where the problem comes from (rather than 10 other examples failing just because the first one failed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also apply this to the quick start example? 🙏
Co-authored-by: Sylvain Combettes <[email protected]>
Co-authored-by: Sylvain Combettes <[email protected]>
Co-authored-by: Sylvain Combettes <[email protected]>
Co-authored-by: Sylvain Combettes <[email protected]>
Co-authored-by: Sylvain Combettes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
fixes #1178