Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Trim all line feed from end of note #1167

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(UI): Trim all line feed from end of note #1167

merged 1 commit into from
Jan 20, 2025

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Jan 20, 2025 •
edited
Loading

When saving a note using shift + enter or meta + enter all line feed at the end will be removed (in frontend aswell as in backend).

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for frontend

Status Category Percentage Covered / Total
🔵 Lines 85.56% 3599 / 4206
🔵 Statements 85.56% 3599 / 4206
🔵 Functions 44.85% 61 / 136
🔵 Branches 79.06% 204 / 258
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
skore-ui/src/views/project/ItemNote.vue 100% 100% 100% 100%
Generated in workflow #113 for commit d3d2c5a by the Vitest Coverage Report Action

@auguste-probabl auguste-probabl merged commit fdbaf29 into probabl-ai:main Jan 20, 2025
7 checks passed
@rouk1 rouk1 mentioned this pull request Jan 20, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomass-dev thomass-dev thomass-dev approved these changes

Assignees

@rouk1 rouk1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rouk1 @thomass-dev @auguste-probabl