Skip to content

Commit

Permalink
ci: Fix timeout by upgrading scikit-learn to latest bugfix (#1141)
Browse files Browse the repository at this point in the history
Co-authored-by: Thomas S. <[email protected]>
  • Loading branch information
glemaitre and thomass-dev authored Jan 17, 2025
1 parent 7fc6808 commit a4dacee
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,12 @@ jobs:
run: |
python -m pip install --upgrade "pip"
python -m pip install --upgrade "build"
python -m pip install --upgrade "scikit-learn ==${{ matrix.scikit-learn }}"
# adding `.*` to the version ensures that we install the latest version of
# scikit-learn that is compatible with the specified version
python -m pip install --upgrade "scikit-learn ==${{ matrix.scikit-learn }}.*"
# Install `skore` and its dependencies
python -m pip install --upgrade ".[test]"
python -m pip install --upgrade --upgrade-strategy=eager ".[test]"
# Uninstall the `skore` package itself
python -m pip uninstall -y "skore"
Expand All @@ -127,6 +129,11 @@ jobs:
# Install `skore` without its dependencies, which are present in the venv
wheel=(dist/*.whl); python -m pip install --force-reinstall --no-deps "${wheel}"
- name: Show dependencies versions
working-directory: skore/
run: |
python -c "import skore; skore.show_versions()"
- name: Test without coverage
if: ${{ ! matrix.coverage }}
timeout-minutes: 10
Expand All @@ -139,7 +146,7 @@ jobs:
working-directory: skore/
run: |
mkdir coverage
python -m pytest src/ tests/ --junitxml=coverage/coverage.xml --cov-config=pyproject.toml --cov | tee coverage/coverage.txt
python -m pytest -n auto src/ tests/ --junitxml=coverage/coverage.xml --cov-config=pyproject.toml --cov | tee coverage/coverage.txt
- name: Upload coverage reports
if: ${{ matrix.coverage && (github.event_name == 'pull_request') }}
Expand Down

0 comments on commit a4dacee

Please sign in to comment.