Skip to content

Commit

Permalink
Fix use of entry-point on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
thomass-dev committed Jan 8, 2025
1 parent 7c6bd55 commit 52c3c26
Showing 1 changed file with 23 additions and 14 deletions.
37 changes: 23 additions & 14 deletions .github/workflows/skore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-latest", "windows-latest"]
python: ["3.9", "3.10", "3.11", "3.12"]
os: ["windows-latest"] # ["ubuntu-latest", "windows-latest"]
python: ["3.12"] # ["3.9", "3.10", "3.11", "3.12"]
scikit-learn: ["1.6"]
include:
- os: "ubuntu-latest"
python: "3.12"
scikit-learn: "1.4"
- os: "ubuntu-latest"
python: "3.12"
scikit-learn: "1.5"
# include:
# - os: "ubuntu-latest"
# python: "3.12"
# scikit-learn: "1.4"
# - os: "ubuntu-latest"
# python: "3.12"
# scikit-learn: "1.5"
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand All @@ -36,7 +36,6 @@ jobs:
path: 'skore/venv'
key: python-venv-${{ matrix.os }}-${{ matrix.python }}-${{ matrix.scikit-learn }}-${{ hashFiles('skore/pyproject.toml') }}


- name: Setup python-venv
working-directory: "skore/"
run: |
Expand All @@ -47,13 +46,18 @@ jobs:
# Activate venv for each step depending on the OS
if [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then
echo "${PWD}/venv/bin" >> ${GITHUB_PATH}
echo "VIRTUAL_ENV=${PWD}/venv" >> ${GITHUB_ENV}
source venv/bin/activate
else
echo "${PWD}/venv/Scripts" >> ${GITHUB_PATH}
echo "VIRTUAL_ENV=${PWD}/venv" >> ${GITHUB_ENV}
venv/Scripts/activate.bat
echo SOURCING"
echo "${PATH}"
fi
echo "EXPORTING"
echo "${PATH}" >> "${GITHUB_PATH}"
echo "VIRTUAL_ENV=${VIRTUAL_ENV}" >> "${GITHUB_ENV}"
- name: Install dependencies
working-directory: "skore/"
if: steps.cache-python-venv.outputs.cache-hit != 'true'
Expand All @@ -73,6 +77,11 @@ jobs:
timeout-minutes: 10
working-directory: "skore/"
run: |
echo $PATH
echo $VIRTUAL_ENV
whereis skore
python -m pip list
# Lint
pre-commit run --all-files ruff
Expand Down

0 comments on commit 52c3c26

Please sign in to comment.