-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bq test problems #838
Add Bq test problems #838
Conversation
Co-authored-by: Marvin Pförtner <[email protected]>
Co-authored-by: Marvin Pförtner <[email protected]>
Co-authored-by: Marvin Pförtner <[email protected]>
… a version of the Genz continuous function transformed to R^d
…into bq-test-problems
ede49e2
to
357fbc1
Compare
…s#585) * rename var -> std in uniform_to_gaussian_quadprob * use pytest-cases
357fbc1
to
f67b865
Compare
Codecov Report
@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 91.17% 91.47% +0.29%
==========================================
Files 218 220 +2
Lines 8241 8552 +311
Branches 1068 1145 +77
==========================================
+ Hits 7514 7823 +309
- Misses 499 500 +1
- Partials 228 229 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks very good! It'll be great to have these test problems in the library. I just have a few minor comments and a clarification question about the timing of the MC tests.
tests/test_problems/test_zoo/test_quad/test_quadproblems_gaussian.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathan Wenger <[email protected]>
* samples 10000000 -> 100000
66fb401
to
4e6fff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
In a Nutshell
Add test problems for BQ from Genz-family and various others.
Detailed Description
Related Issues
Closes #585