Fixed else-if-used pylint message in probnum.problems subpackage
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luffingluffy
requested review from
pnkraemer,
schmidtjonathan and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## main #704 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 194 194
Lines 7343 7343
Branches 1159 1159
=======================================
Hits 6610 6610
Misses 489 489
Partials 244 244
|
pnkraemer
reviewed
Apr 19, 2022
Co-authored-by: Nicholas Krämer <[email protected]>
pnkraemer
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
Fixed the
else-if-usedmessage inprobnum.problemssubpackage.Detailed Description
Changed nested
else-ifstatements toelifto reduce nesting as required by pylint. Stopped ignoring else-if-used issue forprobnum.problemssubpackage by changing configuration intox.ini.Related Issues
Finishes 2nd to-do in #672