-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve pylint line-too-long for linops #682
Merged
JonathanWenger
merged 12 commits into
probabilistic-numerics:main
from
PrSh27:PrSh27-_lineops_pylint_line-too-long
Mar 28, 2022
Merged
Resolve pylint line-too-long for linops #682
JonathanWenger
merged 12 commits into
probabilistic-numerics:main
from
PrSh27:PrSh27-_lineops_pylint_line-too-long
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrSh27
requested review from
marvinpfoertner,
JonathanWenger and
a team
as code owners
March 27, 2022 05:02
PrSh27
changed the title
Pr sh27 lineops pylint line too long
Resolve pylint line-too-long for linops
Mar 27, 2022
JonathanWenger
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
marvinpfoertner
pushed a commit
to marvinpfoertner/probnum
that referenced
this pull request
Mar 29, 2022
* Remove line-to-long for _problems * Remove * Remove line-too-long for _scaling * - * Remove line-too-long from /linops and add to/problems * Update _kronecker.py * Fix trailing-whitespace * Fix trailing whitespace for kroneker * Fix trailing-whitespaces for _linear_operator
marvinpfoertner
added a commit
that referenced
this pull request
Mar 29, 2022
…#685) * Migrate `setup.cfg` to PEP 621 Project Metadata in `pyproject.toml` * Add URLs in `pyproject.toml` testing config * Update `black` configuration * Update `isort` configuration * Add headers for formatting and linting configuration * Move formatting configuration section * Rearrange linting configuration * Add maintainers and authors * Bugfix in `tool.setuptools.platforms` * Bugfix in package collection * Bugfix in `project.optional-dependencies` * Don't need requirements.txt anymore * One line per package dependency * Bugfix in `[project.version]` * Remove authors and maintainers * Bugfix: `optional-dependencies` is generated dynamically * Fix warning in build process: Add `homepage` URL * Update sphinx requirement from <4.5,>=3.0 to >=3.0,<4.6 (#688) * Resolve pylint line-too-long for linops (#682) * Remove line-to-long for _problems * Remove * Remove line-too-long for _scaling * - * Remove line-too-long from /linops and add to/problems * Update _kronecker.py * Fix trailing-whitespace * Fix trailing whitespace for kroneker * Fix trailing-whitespaces for _linear_operator Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PrSh27 <[email protected]>
nirmal-j-patel
pushed a commit
to nirmal-j-patel/probnum
that referenced
this pull request
Apr 1, 2022
* Remove line-to-long for _problems * Remove * Remove line-too-long for _scaling * - * Remove line-too-long from /linops and add to/problems * Update _kronecker.py * Fix trailing-whitespace * Fix trailing whitespace for kroneker * Fix trailing-whitespaces for _linear_operator
nirmal-j-patel
pushed a commit
to nirmal-j-patel/probnum
that referenced
this pull request
Apr 1, 2022
…probabilistic-numerics#685) * Migrate `setup.cfg` to PEP 621 Project Metadata in `pyproject.toml` * Add URLs in `pyproject.toml` testing config * Update `black` configuration * Update `isort` configuration * Add headers for formatting and linting configuration * Move formatting configuration section * Rearrange linting configuration * Add maintainers and authors * Bugfix in `tool.setuptools.platforms` * Bugfix in package collection * Bugfix in `project.optional-dependencies` * Don't need requirements.txt anymore * One line per package dependency * Bugfix in `[project.version]` * Remove authors and maintainers * Bugfix: `optional-dependencies` is generated dynamically * Fix warning in build process: Add `homepage` URL * Update sphinx requirement from <4.5,>=3.0 to >=3.0,<4.6 (probabilistic-numerics#688) * Resolve pylint line-too-long for linops (probabilistic-numerics#682) * Remove line-to-long for _problems * Remove * Remove line-too-long for _scaling * - * Remove line-too-long from /linops and add to/problems * Update _kronecker.py * Fix trailing-whitespace * Fix trailing whitespace for kroneker * Fix trailing-whitespaces for _linear_operator Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PrSh27 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
This PR is to refactor to
line-to-long
for complying with pylint in/probnum/linops
.Detailed Description
Issues solved:
line-too-long
Related Issues
Closes #670