Port/protogalaxy #37
Merged
Port/protogalaxy #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm really excited by getting this!!! Willing to review it ASAP!!! |
arnaucube
force-pushed
the
port/protogalaxy
branch
3 times, most recently
from
bc73e81
to
fdaace6
Compare
arnaucube
force-pushed
the
port/protogalaxy
branch
2 times, most recently
from
a459d4f
to
a001175
Compare
CPerezz
reviewed
Nov 29, 2023
|
Thanks a lot @CPerezz for the time and effort on the review 🙌 Updated the code and in some cases explained some reasoning behind some parts. |
arnaucube
force-pushed
the
port/protogalaxy
branch
from
e40acde
to
d5fae11
Compare
arnaucube
force-pushed
the
port/protogalaxy
branch
2 times, most recently
from
58cf74e
to
f3ec77a
Compare
…apting it to the current folding-schemes lib Port ProtoGalaxy initial version from https://github.com/arnaucube/protogalaxy-poc adapting it to the current folding-schemes lib, which is a first iteration that implements the Lagrange-basis version from [ProtoGalaxy](https://eprint.iacr.org/2023/1106) folding scheme. There are some pending optimizations, but is a first step towards integrating ProtoGalaxy in the library.
arnaucube
force-pushed
the
port/protogalaxy
branch
from
f3ec77a
to
a08e0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This PR currently has low priority to be reviewed]
This PR ports https://github.com/arnaucube/protogalaxy-poc adapting it to the current folding-schemes lib,
which is a first iteration that implements the Lagrange-basis version from ProtoGalaxy (https://eprint.iacr.org/2023/1106) folding scheme.
There are some pending optimizations, but is a first step towards integrating ProtoGalaxy in the library. Currently I'm still prioritizing Nova+CycleFold, once that is ready I'll come back to ProtoGalaxy and iterate it more.