Feature/nova ivc #36
Merged
Feature/nova ivc #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Nova IVC's new & prove_step methods (without CycleFold part yet)
… Transcript trait, refactor NIFS.P to allow absorbing in transcript inbetween
arnaucube
force-pushed
the
feature/nova-ivc
branch
from
e2433c4
to
7b499c7
Compare
…onstraints in AugmentedFCircuit (constraint count went down ~6k)
arnaucube
force-pushed
the
feature/nova-ivc
branch
from
7b499c7
to
fc116a7
Compare
han0110
approved these changes
Nov 10, 2023
CPerezz
reviewed
Nov 22, 2023
Comment on lines
+1
to
+3
| // used for committed instances hash, so when going to the other curve of the cycle it does not | ||
| // overflow the scalar field | ||
| pub const N_BITS_HASH: usize = 250; |
There was a problem hiding this comment.
Can we tie this somehow to F::NUM_BITS or something similar?
CPerezz
approved these changes
Nov 22, 2023
arnaucube
force-pushed
the
feature/nova-ivc
branch
from
1ab4f7a
to
99a2ebc
Compare
…ld, and rm transcript from nova/IVC. - Updates from PR suggestions - Additionally updated: - in nova/nifs.rs: reuse folded_committed_instance for verify_folded_instance, computationally is the same, but reusing the same code so avoiding duplication and having an error on one of the two versions. - in nova/ivc.rs: remove transcript from IVC (not needed, it uses the RO)
arnaucube
force-pushed
the
feature/nova-ivc
branch
from
99a2ebc
to
247c6d6
Compare
|
note: restored the branch of this PR temporarily just to rebase to main some other branches that were depending on this one (as I did also on #35 (comment) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Nova's IVC (new, prove, verify methods) (without the CycleFold part yet).