-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nova ivc #36
Feature/nova ivc #36
Conversation
Implement Nova IVC's new & prove_step methods (without CycleFold part yet)
… Transcript trait, refactor NIFS.P to allow absorbing in transcript inbetween
e2433c4
to
7b499c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just got some small qs
…onstraints in AugmentedFCircuit (constraint count went down ~6k)
7b499c7
to
fc116a7
Compare
// used for committed instances hash, so when going to the other curve of the cycle it does not | ||
// overflow the scalar field | ||
pub const N_BITS_HASH: usize = 250; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we tie this somehow to F::NUM_BITS
or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some suggestions & comments
1ab4f7a
to
99a2ebc
Compare
…ld, and rm transcript from nova/IVC. - Updates from PR suggestions - Additionally updated: - in nova/nifs.rs: reuse folded_committed_instance for verify_folded_instance, computationally is the same, but reusing the same code so avoiding duplication and having an error on one of the two versions. - in nova/ivc.rs: remove transcript from IVC (not needed, it uses the RO)
99a2ebc
to
247c6d6
Compare
note: restored the branch of this PR temporarily just to rebase to main some other branches that were depending on this one (as I did also on #35 (comment) ) |
This PR implements Nova's IVC (new, prove, verify methods) (without the CycleFold part yet).