Refactor Arith trait
#162
Refactor Arith trait
#162
Conversation
folding-schemes/src/arith/ccs.rs
Outdated
| impl<F: PrimeField> Arith<F> for CCS<F> { | ||
| fn eval_relation(&self, z: &[F]) -> Result<Vec<F>, Error> { | ||
| impl<F: PrimeField> CCS<F> { | ||
| pub fn eval_core(&self, z: &[F]) -> Result<Vec<F>, Error> { |
There was a problem hiding this comment.
May I ask why we changed the name to eval_core or at least what core means within this context?
I think if we make the fn pub would be nice to have some minimal docs where we relate the core thing.
There was a problem hiding this comment.
What about eval_z (or eval_at_z)? Will also add the docs!
There was a problem hiding this comment.
Both work for me. Definitely better than core.
|
@winderica can we merge this and start merging the cascade of PRs that depends on this one?? |
|
woah sudden rush @CPerezz hehe. Well, I approved but left a couple of suggestions, and the other PRs will need reviews too. For this one it's missing your approval :P |
|
Sorry for the delay! The reviews should be addressed now :) |
|
ahh 😳 no worries, there has been no delay 🙏 |
winderica
force-pushed
the
refactor-arith-trait
branch
from
95aeed3
to
1d03b67
Compare
|
Are @arnaucube 's suggestions addressed or discussed? Ping once it's done and we can merge! :) |
I understand this as an approve (?) (although the approval check is missing) Regarding my suggestions, they are (greatly) addressed in the last commits, yes ^^ |
f1d8241
As the second part of #145, this PR improves the design of the
Arithtrait with a pair of generic witness and committed instance. TheDummytrait is also introduced, providing a unified interface for thedummymethod.Specifically, unlike the previous
Ariththat can only handlez(a vector of field elements) when checking satisfiability, nowArithandArithGadgetallow for taking the witnesswand instanceuas input, wherewanduare bounded by generic typesWandU:WandUare vectors of field elements, the behavior becomes the same as the previous one.WandUare Nova or ProtoGalaxy instances,ArithandArithGadgetare able to replace theRelaxedR1CSandRelaxedR1CSGadget.WandUare CCS instances, thereby replacing{CCCS, LCCCS}::check_relationandLCCCSCheckerGadget.This is useful because in #145, we will build a generic decider circuit that essentially runs IVC.Verify (including
ArithGadget::enforce_relationand commitment verification) in-circuit without knowing which types of folding scheme, witness, and committed instances are being used.