Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove hardcoded gas limit from signup and publish #1087

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 23, 2024

Description

hardcoded gas limit might prevent transaction from succeeding on certain networks

Related issue(s)

fix #1086

Confirmation

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 1bf3a4b
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65af9f67286ae8000754932c
😎 Deploy Preview https://deploy-preview-1087--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hardcoded gas limit might prevent transaction from succeeding on certain networks

fix #1086
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
I'm curious that does that mean the gas spent more than we set up?

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 23, 2024

thanks! I'm curious that does that mean the gas spent more than we set up?

yes, usually you would set a gas limit when you want the tx to be sent regardless of whether it would fail or not. If you don't specify, and if the tx fails it will just not send it and give you the error. In our case, it seems that on this test network signin up spends more than 1M gas, so the tx would go through but fail because of not enough gas (limit was set to 1M)

@ctrlc03 ctrlc03 merged commit 0e5d633 into dev Jan 23, 2024
17 checks passed
@ctrlc03 ctrlc03 deleted the fix/signup branch January 23, 2024 14:44
@0xmad
Copy link
Collaborator

0xmad commented Jan 23, 2024

@ctrlc03 I created a task for this case #1053. So the idea is to use static calls to check if transaction can be failed without paying for the gas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cannot signup on Arbitrum Sepolia network
3 participants