Skip to content

Commit

Permalink
fix: I'm stupid and += translated to a.assign(b)
Browse files Browse the repository at this point in the history
  • Loading branch information
@CPerezz
CPerezz committed Feb 26, 2024
1 parent c339835 commit bb75cb0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions halo2_backend/src/poly/domain.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -389,14 +389,14 @@ impl<F: WithSmallOrderMulGroup<3>> EvaluationDomain<F> {

parallelize(&mut result[0..(self.n << i) as usize], |result, start| {
for (other, current) in result.iter_mut().zip(a_poly[start..].iter()) {
other.add(current);
other.add_assign(current);
}
});
}
best_fft(&mut result, self.extended_omega, self.extended_k);
parallelize(&mut result_poly.values, |values, start| {
for (value, other) in values.iter_mut().zip(result[start..].into_iter()) {

Check warning on line 398 in halo2_backend/src/poly/domain.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` 

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
   --> halo2_backend/src/poly/domain.rs:398:73
    |
398 |             for (value, other) in values.iter_mut().zip(result[start..].into_iter()) {
    |                                                                         ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `-W clippy::into-iter-on-ref` implied by `-W clippy::all`

Check warning on line 398 in halo2_backend/src/poly/domain.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` 

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
   --> halo2_backend/src/poly/domain.rs:398:73
    |
398 |             for (value, other) in values.iter_mut().zip(result[start..].into_iter()) {
    |                                                                         ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `-W clippy::into-iter-on-ref` implied by `-W clippy::all`

Check failure on line 398 in halo2_backend/src/poly/domain.rs

View workflow job for this annotation

GitHub Actions / Clippy (1.56.1)

this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` 

error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
   --> halo2_backend/src/poly/domain.rs:398:73
    |
398 |             for (value, other) in values.iter_mut().zip(result[start..].into_iter()) {
    |                                                                         ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
value.add(other);
value.add_assign(other);
}
});
result_poly
Expand Down

0 comments on commit bb75cb0

Please sign in to comment.