Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve query graph rendering with graphviz #5143

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jan 30, 2025

  1. Use {:#?} instead of {:?} for better formatting where we use Debug trait to print fields of query graph nodes.

  2. Left-align multiline text in graph nodes (it's centered by default).

Before:

image

After:

image

1. Use `{:#?}` instead of `{:?}` for better formatting where we use
   `Debug` trait to print fields of query graph nodes.

2. Left-align multiline text in graph nodes (it's centered by default).
@aqrln aqrln requested a review from a team as a code owner January 30, 2025 17:55
@aqrln aqrln requested review from FGoessler and removed request for a team January 30, 2025 17:55
@aqrln aqrln added this to the 6.4.0 milestone Jan 30, 2025
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #5143 will not alter performance

Comparing push-kswprvlqxszr (2efb95c) with main (4767cae)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.121MiB 2.120MiB 1.154KiB
Postgres (gzip) 848.675KiB 848.488KiB 192.000B
Mysql 2.083MiB 2.082MiB 1.154KiB
Mysql (gzip) 834.334KiB 834.399KiB -67.000B
Sqlite 1.991MiB 1.990MiB 1.155KiB
Sqlite (gzip) 797.931KiB 797.976KiB -46.000B

@aqrln aqrln merged commit e2a3375 into main Jan 30, 2025
341 checks passed
@aqrln aqrln deleted the push-kswprvlqxszr branch January 30, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants