Pr fix connected blocks, nether portal break double logging #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we only need one portal don't bother checking for more. Closes prism#38 : resolved
IMO the attached checks need an overhaul.
|
There are some issues I noted while looking through the source & testing. Mainly that if there is a portal on each side of an obsidian block, in both implementations only one side will get logged. Also, placing and breaking obsidian in front of a portal will cause the portal to be logged. Even though the portal is not broken. |
|
Prism 3 is essentially in maintenance mode so I'm not likely to merge any refactors. Please commit changes needed to fix specific issues and I'll review them individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38 : resolved