Skip to content

Commit

Permalink
Remove cursor overrides on icons
Browse files Browse the repository at this point in the history
  • Loading branch information
Cameron423698 committed Jul 28, 2014
1 parent d34c2aa commit 1643d0e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
2 changes: 0 additions & 2 deletions octicons/octicons.css
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
cursor: default;
}
.mega-octicon {
font: normal normal 32px octicons;
Expand All @@ -38,7 +37,6 @@
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
cursor: default;
}

.octicon-alert:before { content: '\f02d'} /*  */
Expand Down
4 changes: 1 addition & 3 deletions octicons/octicons.less
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@octicons-font-path: ".";
@octicons-version: "da68501bc1127489ff8587ea0055181abd7913a6";
@octicons-version: "6d0976c7609c435a1353fcfc5de3cd95cee2a673";

@font-face {
font-family: 'octicons';
Expand All @@ -24,7 +24,6 @@
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
cursor: default;
}
.mega-octicon {
font: normal normal 32px octicons;
Expand All @@ -37,7 +36,6 @@
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
cursor: default;
}

.octicon-alert:before { content: '\f02d'} /**/
Expand Down
2 changes: 0 additions & 2 deletions octicons/sprockets-octicons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
cursor: default;
}
.mega-octicon {
font: normal normal 32px octicons;
Expand All @@ -34,7 +33,6 @@
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
cursor: default;
}

.octicon-alert:before { content: '\f02d'} /**/
Expand Down

1 comment on commit 1643d0e

@cameronmcefee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were added in #6, but it's been pointed out that this breaks cursor behavior on <a> octicons. I'd prefer to leave it open to customization by the app rather than be opinionated about the behavior.

Please sign in to comment.