-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Metadata Plugins #154
Support Metadata Plugins #154
Conversation
… to add to the telemetry metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No notes about the code, but
- can you update the changelog?
- what's the use case? What extra annotations would you want to add?
How about an alternative implementation where clients can attach metadata to the absinthe context instead of having this plugin system?
Thanks for the feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice work would be good to update the changes log
Closing this one in favour of: |
This PR introduces a plugin mechanism to allow integrators to specify / create their our metadata.
The plugins are passed as a setup option (metadata_plugins) and get a callback with the Absinthe.Blueprint to extract any information they need