[Feature]: [BE] 카테고리 생성 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
vdvhk12
reviewed
Jan 27, 2025
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("api/v1/categories") |
Comment on lines
29
to
34
| public record CreateCategoryReqBody( | ||
| @NotBlank | ||
| @Length(max = 10) | ||
| String name | ||
| ) { | ||
| } |
There was a problem hiding this comment.
이 부분은 별도 dto로 빼는게 더 좋을 것 같은데, 다른 분들 의견도 한번 들어보고 결정해봅시다 👍
swjoon
approved these changes
Jan 27, 2025
vdvhk12
reviewed
Jan 27, 2025
| public record CategoryDto( | ||
| Long id, | ||
|
|
||
| @NotBlank |
There was a problem hiding this comment.
응답 데이터에는 @notblank 안 붙이셔도 될 것 같아요
이거만 지우고 다시 push 하고 바로 머지 합시다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
✅ PR 포인트 & 궁금한 점