Identify remaining uses of wd0b5
and wd11e
#463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456, and makes pokered 100% labeled!
Formerly
wd0b5
:wCurSpecies
is copied from Gen 2. It's primarily the input argument toGetMonHeader
(akaGetBaseData
in Gen 2).wNameListIndex
is one argument toGetName
, along withwNameListType
(which says whether the index is for a mon, move, item, or trainer).Formerly
wd11e
:wNamedObjectIndex
is copied from Gen 2. I could have defined separate labels for Pokemon, item, and move IDs, but there's enough overlap (e.g. functions that sometimes print one and sometimes another, or how the genericGetName
outputs to this) that I thought this was better.wTempByteValue
is copied from Gen 2. Used in a few places for very local values, e.g. a place to stash+retrieve a value that's used only in one function or even in one "paragraph" of one function.wPokedexNum
is "theIndexToPokedex
orPokedexToIndex
variable"; it acts as both input and output, i.e. both species and Pokedex number.wTempTMHM
is copied from Gen 2. It's "theTMToMove
variable" (akaGetTMHMMove
in Gen 2): it acts as both input and output, e.g. both TM item number and move number.wMoveGrammar
is copied from Gen 2. It's "theDetermineExclamationPointTextNum
variable" (akaGetMoveGrammar
in Gen 2): it acts as both input and output, i.e. both move ID and grammar/exclamation index (0-3).