Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for content type for remote files #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bsislow-or
Copy link

Issue Resolution:

When parsing a file with invalid html, there is a possibility that the following html could be parsed:

<link rel="stylesheet" type="text/css" href="SomeFont.otf">

The above is a css link tag with a font as the href
In this case the parser will pull down the file and attempt to process it. There are certain cases where this takes a non trivial amount of time to parse and can even stall out applications waiting for the parser to complete based on the contents of the font or non css file.

Since this should not handle invalid file types, this PR checks for the proper content type and responds with a RemoteFile Error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant