Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

script for setup of redis binary service #131

Merged
merged 6 commits into from
Nov 3, 2023
Merged

script for setup of redis binary service #131

merged 6 commits into from
Nov 3, 2023

Conversation

biswaroop1547
Copy link
Collaborator

@biswaroop1547 biswaroop1547 commented Nov 3, 2023 •
edited by casperdcl
Loading

casperdcl
casperdcl suggested changes Nov 3, 2023
View reviewed changes
vec-redis/setup-redis.sh Outdated Show resolved Hide resolved
vec-redis/setup-redis.sh Outdated Show resolved Hide resolved
vec-redis/setup-redis.sh Outdated Show resolved Hide resolved
@biswaroop1547 @casperdcl
update: suggestions from code review
d3ef17c 
Co-authored-by: Casper da Costa-Luis <[email protected]>
@biswaroop1547 biswaroop1547 marked this pull request as draft November 3, 2023 13:50
casperdcl
casperdcl reviewed Nov 3, 2023
View reviewed changes
vec-redis/setup-redis.sh Outdated Show resolved Hide resolved
casperdcl
casperdcl reviewed Nov 3, 2023
View reviewed changes
vec-redis/setup-redis.sh Outdated Show resolved Hide resolved
@biswaroop1547 @casperdcl
fix: vec-redis script correct path
1135e12 
Co-authored-by: Casper da Costa-Luis <[email protected]>
casperdcl
casperdcl previously approved these changes Nov 3, 2023
View reviewed changes
@casperdcl casperdcl added the enhancement New feature or request label Nov 3, 2023
casperdcl
casperdcl reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw probably wanna forward args, right? could use to configure ports etc. https://stackoverflow.com/q/55078246

vec-redis/setup-redis.sh Outdated Show resolved Hide resolved
vec-redis/setup-redis.sh Outdated Show resolved Hide resolved
@casperdcl
Copy link
Contributor

btw the failing (nonexistent) docker build can either be ignored, or replaced with a simple FROM redis/redis-stack-server:7.2.0-v6 or similar

@biswaroop1547 biswaroop1547 marked this pull request as ready for review November 3, 2023 15:12
@casperdcl casperdcl merged commit f6738cb into premAI-io:main Nov 3, 2023
7 of 9 checks passed
@casperdcl casperdcl mentioned this pull request Nov 3, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@biswaroop1547 biswaroop1547

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biswaroop1547 @casperdcl