Add codespell (config, workflow) to catch typos + catch and fix some of those #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks! This has caught some pretty nasty typos! 🚀 |
baszalmstra
reviewed
Sep 11, 2023
src/project/mod.rs
Outdated
| @@ -905,7 +905,7 @@ mod tests { | |||
| let file_contents = [ | |||
| r#" | |||
| [system-requirements] | |||
| libc = { verion = "2.12" } | |||
There was a problem hiding this comment.
I think this one was done on purpose :)
There was a problem hiding this comment.
done -- ignored now
baszalmstra
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Wow this looks great! Thanks @yarikoptic !
Would you be able to fix the remaining CI issues? The test is failing because we test that an explicit misspelling of version causes an error during parsing but your changes "fixed" the misspelling. :) I left a comment where this happens.
yarikoptic
force-pushed
the
enh-codespell
branch
from
7525ea2
to
e2d8e73
Compare
|
fixed up for that |
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
wolfv
force-pushed
the
enh-codespell
branch
from
d8cf8e8
to
173e296
Compare
wolfv
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: some fixes seems to be touching code and could be "functional"