feat: add isolated build tools #2479
Open
+642
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
requested changes
Nov 15, 2024
| /// The tool context, | ||
| /// containing client, channels and gateway configuration | ||
| /// that will be used to resolve and install tools. | ||
|
|
|
|
||
| #[derive(Default, Debug)] | ||
| pub struct ToolContext { | ||
| /// The gateway configuration used to fetch repodata. |
There was a problem hiding this comment.
Suggested change
| /// The gateway configuration used to fetch repodata. | |
| /// The gateway configuration that is used to fetch repodata. |
| pub struct ToolContext { | ||
| /// The gateway configuration used to fetch repodata. | ||
| pub gateway_config: ChannelConfig, | ||
| /// Authenticated client to use for fetching repodata. |
There was a problem hiding this comment.
Suggested change
| /// Authenticated client to use for fetching repodata. | |
| /// Authenticated client used to fetch repodata. |
| .recursive(true) | ||
| .execute() | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
Maybe get rid of these unwrap's
| cache_dir: &Path, | ||
| context: ToolContext, | ||
| ) -> miette::Result<IsolatedTool> { | ||
| let gateway = Gateway::builder() |
There was a problem hiding this comment.
This needs to because the in-memory cache is not shared otherwise.
| } | ||
|
|
||
| impl BuildSection { | ||
| pub fn channels_url(&self, config: &ChannelConfig) -> Result<Vec<Url>, ParseChannelError> { |
| @@ -7,6 +7,7 @@ platforms = ["win-64", "linux-64", "osx-arm64", "osx-64"] | |||
|
|
|||
| [build] | |||
| build-backend = "pixi-build-cmake" | |||
| channels = ["https://prefix.dev/graf", "https://fast.prefix.dev/conda-forge"] | |||
| @@ -21,7 +21,9 @@ platforms = ["linux-64", "osx-arm64", "osx-64", "win-64"] | |||
| flask-hello-world-pyproject = { path = ".", editable = true } | |||
|
|
|||
| [tool.pixi.dependencies] | |||
| flask = "2.*" | |||
| # flask = "2.*" | |||
| [build] | ||
| build-backend = "pixi-build-python" | ||
| channels = [ | ||
| "file:///Users/graf/projects/oss/pixi-build-backends/output", |
There was a problem hiding this comment.
Lets not add local paths.
| parsed_manifest["tool"]["pixi"]["host-dependencies"] = {"hatchling": "*"} | ||
| parsed_manifest["tool"]["pixi"]["build"] = { | ||
| "build-backend": "pixi-build-python", | ||
| "channels": ["https://prefix.dev/graf", "https://fast.prefix.dev/conda-forge"], |
There was a problem hiding this comment.
Can we use the other channel here?
|
Would be great to add the following follow-up PR's:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--with-systemoption for pixi build. This mean that pixi instead of installing these tools, will use the one present in system. It was not possible to use these features previously.channelsin build table. This means that user can specify some private / or different channels to get their build tools. This is also handy for us because we host currently our build tools on pixi-build-backends channel.It cache the env based on the command, spec and channels.
This is also a small demo of end-2-end result
Screen.Recording.2024-11-13.at.18.57.38.mov