-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: testing common wheels #2031
Merged
ruben-arts
merged 37 commits into
prefix-dev:main
from
tdejager:test/test-common-wheels
Sep 17, 2024
Merged
test: testing common wheels #2031
ruben-arts
merged 37 commits into
prefix-dev:main
from
tdejager:test/test-common-wheels
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed all wheel problems
Nice this is great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small, preliminary review
Co-authored-by: Hofer-Julian <[email protected]>
1. Use file locking, I saw file corruption in CI 2. make ci tests red again 3. Remove 2 failing wheels for windows
ruben-arts
approved these changes
Sep 16, 2024
Hofer-Julian
approved these changes
Sep 16, 2024
Are we now sure it fails if a wheel fails to install? |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new testings suite that uses pytest and pixi to test common wheels, thanks: @liblaf for the inspiration! See: https://github.com/liblaf/pixi-test
This PR add two pixi tasks:
test-common-wheels
requires a build and tests the installation of some common wheels*-ci
task does the same but does not have thedepends-on
There is a
wheels.toml
file that contains a small configuration structure for defining the wheels that should be tested in CI. The tests contain the necessary files to actually parse and execute upon these functions. The tests are run in parallel usingpython-xdist
.Running tests locally
Running the tests locally should give you something like:
Running in CI
In CI a github markdown summary should be generated for somewhat easier parsing, of the wheels that were tested.
Adding extra wheels
To add extra wheels the
wheels.toml
file can be modified and a PR can be made.Further improvements
uv
should a failure occur.