feat: adds the ability to set the index strategy #1986
Merged
+969
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
approved these changes
Sep 5, 2024
…eat/index-strategy
Co-authored-by: Hofer-Julian <[email protected]>
|
BTW I forgot, but before merging we need to change the schema and add docs. |
Unrelated to this PR, but I already wondered why we generate the schema from pydantic instead from our Rust struct. I assume that's not easy to do with serde? |
I think the last time we checked that crate was less expressive? |
Done. |
baszalmstra
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables to set the UV
index-strategyfrom pixi. I would like a test for this so it is still in draft for now :)closes: #1377