Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds the ability to set the index strategy #1986

Merged
merged 15 commits into from
Sep 10, 2024

Conversation

tdejager
Copy link
Contributor

@tdejager tdejager commented Sep 5, 2024

This PR enables to set the UV index-strategy from pixi. I would like a test for this so it is still in draft for now :)

closes: #1377

@baszalmstra baszalmstra marked this pull request as ready for review September 10, 2024 06:59
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Ony had minor comments

pixi.toml Show resolved Hide resolved
tests/pypi-indexes/generate-indexes.py Outdated Show resolved Hide resolved
crates/pixi_manifest/src/pypi/pypi_options.rs Outdated Show resolved Hide resolved
@tdejager
Copy link
Contributor Author

BTW I forgot, but before merging we need to change the schema and add docs.

@Hofer-Julian
Copy link
Contributor

BTW I forgot, but before merging we need to change the schema and add docs.

Unrelated to this PR, but I already wondered why we generate the schema from pydantic instead from our Rust struct. I assume that's not easy to do with serde?

@tdejager
Copy link
Contributor Author

BTW I forgot, but before merging we need to change the schema and add docs.

Unrelated to this PR, but I already wondered why we generate the schema from pydantic instead from our Rust struct. I assume that's not easy to do with serde?

I think the last time we checked that crate was less expressive?

@tdejager
Copy link
Contributor Author

BTW I forgot, but before merging we need to change the schema and add docs.

Done.

@tdejager tdejager enabled auto-merge (squash) September 10, 2024 09:30
@tdejager tdejager merged commit 78850aa into prefix-dev:main Sep 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose different uv index resolution strategies
3 participants