feat: variants in metadata #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
feat/variants_in_metadata
branch
from
4d21b51 to
941de05
Compare
tdejager
requested changes
Jan 16, 2025
| @@ -362,6 +348,38 @@ impl CMakeBuildBackend { | |||
| sandbox_config: None, | |||
| }) | |||
| } | |||
|
|
|||
| pub fn compute_variants( | |||
| @@ -322,31 +323,15 @@ impl PythonBuildBackend { | |||
| } | |||
|
|
|||
| /// Returns the build configuration for a recipe | |||
There was a problem hiding this comment.
Lets improve these docs to be a bit less general :)
| @@ -397,6 +381,38 @@ impl PythonBuildBackend { | |||
| sandbox_config: None, | |||
| }) | |||
| } | |||
|
|
|||
| pub fn compute_variants( | |||
|
I added more docs to the PR, let me know what you think! @tdejager |
tdejager
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the code to use passed in variants for both build and metadata.