Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of packages in Quickstart #577

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

SyedMustafaAhmad
Copy link
Contributor

I am taking the Simulation Software Engineering course and I was looking for an installation candidate for Ubuntu 24.04 .deb file. The .deb file link was missing in the Installation guide but it was present in the releases pages so I've added the newer release 3_3.1.2 for all other versions as well as for Ubuntu 24.04

Ubuntu 24.04 .deb file link was missing in the Installation guide but it was present in the releases pages so I've added the newer release 3_3.1.2 for all other versions as well as for Ubuntu 24.04
@SyedMustafaAhmad SyedMustafaAhmad changed the title Added Ubuntu 24.04 as an available option in the Installation Added Ubuntu 24.04 as an available option in the Installation Guide Oct 16, 2024
@MakisH
Copy link
Member

MakisH commented Oct 17, 2024

Good catch, thank you! 🤗

As you can see in the "Files changed" view (and in the CI check at the bottom of this page), there are a few formatting-related changes that are not related to the change. While I can easily fix this myself, I think it would be a good exercise for you to try it out.

@MakisH MakisH self-requested a review October 17, 2024 08:50
@MakisH MakisH self-assigned this Oct 17, 2024
@SyedMustafaAhmad
Copy link
Contributor Author

Thank you for the reply.

Yes, I can see the unrelated formatting issues. I think my text editor auto-incremented the numbering. I'll fix that and edit the request.

@MakisH MakisH changed the title Added Ubuntu 24.04 as an available option in the Installation Guide Update list of packages in Quickstart Oct 18, 2024
quickstart/README.md Outdated Show resolved Hide resolved
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the suggested preCICE version looks correct, and the names of the distribution versions are also correct.

I have not checked how the rendered website looks like, but I see no possibility for messing up. And the CI is passing.

Thanks again for contributing!

@MakisH MakisH merged commit 77f190d into precice:develop Oct 21, 2024
1 check passed
@SyedMustafaAhmad
Copy link
Contributor Author

Thank you for accepting my contribution.

I learned a lot by going through the process.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants