Create venv in participant folder, not in common solver folder. #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the usage of the
venvin #557 introduced some form of race condition if the participants try to create thevenvat the same time at the same place (../solver-fenics/.venv). This happens, for example, in this test.To avoid this race condition I would suggest to create the
venvin the folder of the participant (dirichlet/neumann-fenics) but still keep therequirements.txt(to avoid duplication) insolver-fenics.@NiklasVin this also applies to the other cases in #563. I would suggest to only deal with the partitioned heat conduction case here. If merging this PR fixes the test mentioned above we can roll out this improvement to all cases,