Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python variant of resonant circuit #498

Merged
merged 22 commits into from
Aug 30, 2024
Merged

Add python variant of resonant circuit #498

merged 22 commits into from
Aug 30, 2024

Conversation

BenjaminRodenberg
Copy link
Member

Add a python version of the tutorial provided via #480. Uses a black-box time stepper with time interpolation and substeps for high accuracy.

Planning to merge #480 first.

@BenjaminRodenberg BenjaminRodenberg self-assigned this Mar 22, 2024
@BenjaminRodenberg BenjaminRodenberg changed the base branch from master to develop March 25, 2024 12:40
@BenjaminRodenberg
Copy link
Member Author

It's to some degree an open question where we want to go from here: I added adaptive time stepping and use time interpolation in this PR. This is similar to what I did in #500. From my perspective the resonant circuit is even a bit simpler and might help to illustrate advanced time stepping techniques quite well.

@MakisH
Copy link
Member

MakisH commented Jun 27, 2024

I ported the fix for the markdownlint CI check. This is now only failing for autopep8.

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review August 29, 2024 09:05
BenjaminRodenberg
BenjaminRodenberg commented Aug 29, 2024
View reviewed changes
Copy link
Member Author

@BenjaminRodenberg BenjaminRodenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's still missing here: We need a requirement.txt and update this case to use venv (see #547). Either I or @NiklasVin will take care of this.

@BenjaminRodenberg BenjaminRodenberg changed the title WIP: Add python version of resonant circuit Add python version of resonant circuit Aug 29, 2024
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Aug 29, 2024
Open
MakisH
MakisH reviewed Aug 29, 2024
View reviewed changes
resonant-circuit/README.md Outdated Show resolved Hide resolved
@MakisH MakisH changed the title Add python version of resonant circuit Add python variant of resonant circuit Aug 29, 2024
@BenjaminRodenberg BenjaminRodenberg removed their assignment Aug 29, 2024
@BenjaminRodenberg
Copy link
Member Author

I did a quick round of checks for the newly added requirements.txt and modified ./run.sh script and everything works. Thanks for adding @NiklasVin !

@NiklasVin
Copy link
Collaborator

@MakisH Everything should be fine now. Could you please review this PR again?

MakisH
MakisH reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run the tutorial (but don't know what results to check if I only run Python-Python).

The files looks very clean and ready to merge.

resonant-circuit/README.md Outdated Show resolved Hide resolved
@BenjaminRodenberg BenjaminRodenberg self-assigned this Aug 30, 2024
@BenjaminRodenberg BenjaminRodenberg merged commit b80509a into precice:develop Aug 30, 2024
1 check passed
@BenjaminRodenberg BenjaminRodenberg deleted the add-lc-circuit-python branch August 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH MakisH approved these changes

Assignees

@BenjaminRodenberg BenjaminRodenberg

@NiklasVin NiklasVin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminRodenberg @MakisH @NiklasVin