Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put computation of counting active steps inside the adaptivity variant condition #130

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Put computation of counting active steps inside the adaptivity variant condition #130

merged 2 commits into from
Sep 16, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Sep 16, 2024 •
edited
Loading

Fixes #122

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Sep 16, 2024
@IshaanDesai IshaanDesai added the bug Something isn't working label Sep 16, 2024
@IshaanDesai IshaanDesai marked this pull request as ready for review September 16, 2024 14:22
mathiskelm
mathiskelm approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding the fix.

@IshaanDesai IshaanDesai merged commit c815977 into develop Sep 16, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the fix_active_steps branch September 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiskelm mathiskelm mathiskelm approved these changes

Assignees

@IshaanDesai IshaanDesai

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overcounted active steps when using adaptivity in every implicit iteration
2 participants
@IshaanDesai @mathiskelm