Use absolute values to calculate normalizing factor for relative norms in adaptivity #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title states, absolute values of quantities need to be compared while picking the maximum value from a pair of values, to use as the normalizing factor for relative norms in the adaptivity computation. This is important when two negative values, or a negative value and a zero value are being compared in the adaptivity computation. @mathiskelm pointed this out.
Checklist:
CHANGELOG.md
.