Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute values to calculate normalizing factor for relative norms in adaptivity #125

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Aug 13, 2024

As the title states, absolute values of quantities need to be compared while picking the maximum value from a pair of values, to use as the normalizing factor for relative norms in the adaptivity computation. This is important when two negative values, or a negative value and a zero value are being compared in the adaptivity computation. @mathiskelm pointed this out.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai changed the title Corrections to norm calculations in the adaptivity Use absolute values to calculate normalizing factor for relative norms in adaptivity Aug 14, 2024
@IshaanDesai IshaanDesai self-assigned this Aug 14, 2024
@IshaanDesai IshaanDesai added the bug Something isn't working label Aug 14, 2024
@IshaanDesai IshaanDesai marked this pull request as ready for review August 14, 2024 07:39
@IshaanDesai IshaanDesai linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link
Collaborator

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@IshaanDesai IshaanDesai merged commit 490ae43 into develop Aug 14, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the norm-corrections branch August 14, 2024 08:13
@IshaanDesai IshaanDesai mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unbounded relative similarity measure for negative values
2 participants