Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker support #87

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DefeNder93
Copy link

Docker support was added. For build, run, stop commands shell scripts were created. Port and container name can be specified. NodeJS + express was used as simple web server.

@DefeNder93 DefeNder93 changed the title Feature/webpack support Feature/docker support Sep 11, 2017
package.json Outdated
@@ -4,7 +4,7 @@
"description": "A workflow for Angular made with Webpack",
"scripts": {
"build": "rimraf dist && webpack --bail --progress --profile",
"server": "webpack-dev-server --host 0.0.0.0 --port 8080 --history-api-fallback --inline --progress",
"server": "webpack-dev-server --history-api-fallback --inline --progress",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was the command changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it by this commit. In the first place, I wanted to use webpack-dev-server and I needed to change host to 0.0.0.0 to make it work (to fix ERR_CONNECTION_REFUSED error). But then I realized that it's better to use separated web-server (in this case express) and build command because webpack-dev-server is not good for production.

Copy link
Member

@phra phra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i don't know if this should be part of the scope of this starter project, also because it's a client-side only application so benefits of using docker are very limited (or not existing at all)

@phra phra requested a review from Foxandxss September 11, 2017 13:15
@DefeNder93
Copy link
Author

@phra benefit from using Docker is good starting point for deploy on production. You right, it's a client-side app, but it needs to be deployed someday, and with Docker, it can be easily done.

@itsmunim
Copy link

itsmunim commented Dec 24, 2017

@phra I think with docker included it becomes a good entry point for people who are looking for a simple enough client side app setup with a backend for frontend(e.g. the node server). Anybody can work from there and make it a full-fledged deployable solution.

But, I agree that for a simple enough client app(e.g. a static portfolio or demo page), it might be an overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants