Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Loopme #4023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New Adapter: Loopme #4023

wants to merge 2 commits into from

Conversation

ambalashov
Copy link

No description provided.

adapters/loopme/loopme.go Outdated Show resolved Hide resolved
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7d984d9

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:20:	MakeRequests	88.9%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:54:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:92:	parseBidderExt	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:105:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:123:	Builder		75.0%
total:									(statements)	94.5%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a239d73

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:20:	MakeRequests	88.9%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:54:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:92:	parseBidderExt	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:105:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:123:	Builder		75.0%
total:									(statements)	94.5%

@bsardo bsardo changed the title Loopme: add bidder adapter New Adapter: Loopme Nov 4, 2024
@bsardo
Copy link
Collaborator

bsardo commented Nov 4, 2024

Hi @ambalashov, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants